Show VM transform button only if permitted

[smelamud]

Show VM transform button for mass transforms only if vm_transform_mass permission is set in the permission store. By default, it is visible in ManageIQ, that uses Null permission store, and hidden in CFME, if vm_transform_mass is not set explicitly in YAML permission store.

[smelamud]

@miq-bot assign martinpovolny

[smelamud]

@miq-bot add_labels gaprindashvili/yes

[martinpovolny]

@smelamud: looks good but there's "but" ;-)

Can you, please, extract the common behavior from the 2 button classes? (a common parent class or a module?)

Why do the 2 implementations of destination_exists? differ? That does not look right.

Thank you!

[smelamud]

@martinpovolny Because TransformVmButton was written by Martin Betak and MassTransformVmButton was written by me and I changed the implementation according to reviewers' comments.

[smelamud]

@martinpovolny I can change the implementation in TransformVmButton or even create a common ancestor for both buttons, but this is out of scope of this PR. I can create a separate PR for this.

[oourfali]

@martinpovolny can we merge this?
Other changes can be done in subsequent patches.

[miq-bot]

Checked commit smelamud@3f07554 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

[smelamud]

@jelkosz Enabled the button for single VM transforms, as we discussed.

[jelkosz]

@smelamud great, thank you!

[martinpovolny]

@jelkosz Enabled the button for single VM transforms, as we discussed.

Now I am lost. Why did you do that? Is that discussion somewhere I can read?

[smelamud]

@martinpovolny It was just my misunderstanding. I thought I should hide transform VM button everywhere, but Tomas said I need to hide only mass transforms button, but single VM transforms should be present.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 865e73b1efb68c7a212a754c364d058fcc666a4c
Author: Martin Povolny <[email protected]>
Date:   Thu Dec 14 14:14:38 2017 +0100

    Merge pull request #2959 from smelamud/disable-vm-transform-in-cfme
    
    Show VM transform button only if permitted
    (cherry picked from commit aa625cd92253c41ab87e649f47c775f98c7eba08)