Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PDF and full-screen links for dashboard widgets #2955

Merged

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Dec 5, 2017

  1. Go to Cloud Intel -> Dashboard
  2. for each and every widget present, try do download its PDF report (if possible). Correct report should be rendered, no error should occur.
  3. for each and every widget present, try to go full screen (if possible). Correct report should be rendered, no error should occur.

for rr_id=... we need to correctly pass the report result id, not the widget id.

https://bugzilla.redhat.com/show_bug.cgi?id=1518949
https://bugzilla.redhat.com/show_bug.cgi?id=1517059

for rr_id=... we need to correctly pass the report result id, not
the widget id.

https://bugzilla.redhat.com/show_bug.cgi?id=1518949
@miq-bot
Copy link
Member

miq-bot commented Dec 5, 2017

Checked commit mzazrivec@c0d7dfd with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

app/presenters/widget_presenter.rb

  • ❗ - Line 65, Col 20 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

@himdel
Copy link
Contributor

himdel commented Dec 5, 2017

LGTM, tested in the UI...

I still get 2 exceptions here (as opposed to 5 before), but now the opened reports actually match the right graph 👍

(I'm guessing the remaining exceptions have to do with the result having been generated before the changes that would make miq_group_id non-NULL - either that or a second bug.)

(Also I notice that fullscreen reports now seem to be using the login layout, not application, for some reason.)

@himdel himdel merged commit 892f035 into ManageIQ:master Dec 5, 2017
@himdel himdel self-assigned this Dec 5, 2017
@himdel himdel added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 5, 2017
simaishi pushed a commit that referenced this pull request Dec 11, 2017
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 70d64915ab0e5f8fe27d05ae10c9dee98709dfa4
Author: Martin Hradil <[email protected]>
Date:   Tue Dec 5 18:18:55 2017 +0000

    Merge pull request #2955 from mzazrivec/fix_pdf_and_fs_links_in_dashboard_widgets
    
    Fix PDF and full-screen links for dashboard widgets
    (cherry picked from commit 892f035cd2577f16788d93950757348bbefb43a0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1524637
    https://bugzilla.redhat.com/show_bug.cgi?id=1524638

@mzazrivec mzazrivec deleted the fix_pdf_and_fs_links_in_dashboard_widgets branch February 22, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants