Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the flash_msg_div before displaying new flashes during login #2950

Merged
merged 1 commit into from
Dec 8, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Dec 5, 2017

This hides any previously displayed flash messages from the login screen, see the BZ for details.

https://bugzilla.redhat.com/show_bug.cgi?id=1516734

@miq-bot
Copy link
Member

miq-bot commented Dec 5, 2017

Checked commit skateman@661b95b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Dec 8, 2017
@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 8, 2017
@mzazrivec mzazrivec merged commit f5382d5 into ManageIQ:master Dec 8, 2017
@skateman skateman deleted the clear-flash-login branch December 8, 2017 10:13
simaishi pushed a commit that referenced this pull request Dec 11, 2017
Clear the flash_msg_div before displaying new flashes during login
(cherry picked from commit f5382d5)

https://bugzilla.redhat.com/show_bug.cgi?id=1524705
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 749c43cce09acd6667324c4357b8efffc3e3ed80
Author: Milan Zázrivec <[email protected]>
Date:   Fri Dec 8 11:00:18 2017 +0100

    Merge pull request #2950 from skateman/clear-flash-login
    
    Clear the flash_msg_div before displaying new flashes during login
    (cherry picked from commit f5382d5f57b3adec04e13f2a77d5c1b6fe9255c4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1524705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants