Dashboard - fullscreen - open in new tab

[himdel]

This makes the "Full Screen" button in Dashboard widgets open the fullscreen version in a new window/tab.

Cc @martinpovolny, @ZitaNemeckova

[himdel]

There was already support for clickAction - but onclick can't be used in angular html (compile error), so to use that we'd have to

diff --git a/app/assets/javascripts/components/dropdown-menu.js b/app/assets/javascripts/components/dropdown-menu.js
index 3e8aa2474e..655fccc43e 100644
--- a/app/assets/javascripts/components/dropdown-menu.js
+++ b/app/assets/javascripts/components/dropdown-menu.js
@@ -11,6 +11,15 @@ ManageIQ.angular.app.component('dropdownMenu', {
       vm.dropdown_id = 'btn_' + vm.id;
       vm.buttons = JSON.parse(vm.buttonsData);
     };
+
+    this.customAction = function($event, action) {
+      if (!action) {
+        return;
+      }
+
+      (new Function(action)).call($event.target);
+      $event.preventDefault();
+    };
   },
   templateUrl: "/static/dropdown-menu.html.haml",
 });
diff --git a/app/views/static/dropdown-menu.html.haml b/app/views/static/dropdown-menu.html.haml
index 621000be0f..571ba5d86a 100644
--- a/app/views/static/dropdown-menu.html.haml
+++ b/app/views/static/dropdown-menu.html.haml
@@ -15,6 +15,7 @@
          'ng-attr-data-remote' => "{{button.dataRemote}}",
          'data-confirm'        => "{{button.confirm}}",
          'href'                => "{{button.href}}",
-         'data-miq_sparkle_on' => "{{button.sparkleOn ? 'true' : 'false'}}"}
+         'data-miq_sparkle_on' => "{{button.sparkleOn ? 'true' : 'false'}}",
+         'ng-click'            => "vm.customAction($event, button.clickAction)"}
         %span{'ng-class' => "button.fonticon"}
         {{button.name}}

.. and the we hit the problem that the function does not read data-confirm, only data-miq_confirm, etc.

Seems cleaner to drop the clickAction code and just add support for target.

[miq-bot]

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/ae76b7d038904d82166dc164aa99a339aa289da1 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

app/presenters/widget_presenter.rb

• ❗ - Line 67, Col 20 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

[h-kataria]

looks good.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit ebdf125bfe7e70329109dd4cb000c33edc95c19d
Author: Dan Clarizio <[email protected]>
Date:   Mon Dec 4 15:31:56 2017 -0800

    Merge pull request #2920 from himdel/widget-fullscreen
    
    Dashboard - fullscreen - open in new tab
    (cherry picked from commit a5bb860375fb541530f8752e25f017639c1d4cad)