Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update menu icons #2917

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Update menu icons #2917

merged 1 commit into from
Apr 9, 2018

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Dec 4, 2017

Update vertical nav font icons for Automate and Optimize. (Depends on upgrade to Patternfly Sass 3.23.1)

Old
screen shot 2017-12-07 at 9 08 02 am

New
screen shot 2017-12-07 at 9 07 49 am

@epwinchell
Copy link
Contributor Author

@miq-bot add_label wip, graphics, enhancement

@miq-bot miq-bot changed the title Update menu icons [WIP] Update menu icons Dec 4, 2017
@miq-bot miq-bot changed the title [WIP] Update menu icons Update menu icons Dec 4, 2017
@miq-bot miq-bot removed the wip label Dec 4, 2017
@miq-bot
Copy link
Member

miq-bot commented Dec 4, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/7fae7123020e8a5f998a6d1ed18c21182d680d1b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@epwinchell
Copy link
Contributor Author

@miq-bot add_label wip

@miq-bot miq-bot changed the title Update menu icons [WIP] Update menu icons Dec 4, 2017
@miq-bot miq-bot added the wip label Dec 4, 2017
@epwinchell
Copy link
Contributor Author

@serenamarie125 Please review

@serenamarie125
Copy link

@epwinchell automation is 👍

@serenamarie125
Copy link

@epwinchell I need to verify on the Optimize, as something has recently come up regarding the icon. Will comment back by EOB 08-Dec.

@epwinchell
Copy link
Contributor Author

@miq-bot add_label ux/review

@epwinchell
Copy link
Contributor Author

ping @serenamarie125

@serenamarie125
Copy link

@epwinchell this still says WIP, are you ready for review?

Copy link

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epwinchell re: optimize, looks great, thanks for using pficon-optimize & pficon-automation

@serenamarie125
Copy link

@miq-bot add_labels ux/approved
@miq-bot remove_labels ux/review

@epwinchell
Copy link
Contributor Author

@martinpovolny ready to merge

@epwinchell
Copy link
Contributor Author

@miq-bot rm_label wip

@miq-bot miq-bot changed the title [WIP] Update menu icons Update menu icons Apr 8, 2018
@miq-bot miq-bot removed the wip label Apr 8, 2018
@martinpovolny martinpovolny merged commit 8f656ab into ManageIQ:master Apr 9, 2018
@martinpovolny martinpovolny added this to the Sprint 83 Ending Apr 9, 2018 milestone Apr 9, 2018
@martinpovolny martinpovolny self-assigned this Apr 9, 2018
@epwinchell epwinchell deleted the menu_update branch March 20, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants