Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view type switching in Generic Objects #2907

Merged

Conversation

AparnaKarve
Copy link
Contributor

Fixes grid-tile-list view switching in the Generic Object Definitions page as well as Generic Object instances page.

https://bugzilla.redhat.com/show_bug.cgi?id=1518824

@AparnaKarve
Copy link
Contributor Author

@miq_bot add_label bug,gaprindashvili/yes,generic objects

@AparnaKarve AparnaKarve force-pushed the bz1518824_switch_to_g_t_l_views branch from ff5deb8 to 02dfefe Compare December 1, 2017 21:16
@miq-bot
Copy link
Member

miq-bot commented Dec 1, 2017

Checked commits AparnaKarve/manageiq-ui-classic@d44babd~...02dfefe with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@dclarizio dclarizio self-assigned this Dec 1, 2017
@dclarizio dclarizio merged commit 63c59d9 into ManageIQ:master Dec 1, 2017
@dclarizio dclarizio added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 1, 2017
simaishi pushed a commit that referenced this pull request Dec 4, 2017
@simaishi
Copy link
Contributor

simaishi commented Dec 4, 2017

Gaprindashvili backport details:

$ git log -1
commit 6bce8bb0561b42d26b562d421281b19a117bf917
Author: Dan Clarizio <[email protected]>
Date:   Fri Dec 1 14:00:11 2017 -0800

    Merge pull request #2907 from AparnaKarve/bz1518824_switch_to_g_t_l_views
    
    Fix view type switching in Generic Objects
    (cherry picked from commit 63c59d90d7c01230e661a8d56185147cf7a6b0fa)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants