Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete action to flavor toolbar #2900

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

alexander-demicev
Copy link

Adds delete action to flavor toolbar.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1519236

@miq-bot
Copy link
Member

miq-bot commented Dec 2, 2017

Checked commit alexander-demicev@25756f0 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 2 offenses detected

app/helpers/application_helper/toolbar/flavor_center.rb

  • ❗ - Line 19, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 3, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

button(
:flavor_delete,
'pficon pficon-delete fa-lg',
t = N_('Remove Flavor'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Loicavenel should this be Remove Flavor or rather Remove Flavor from Inventory ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, never mind. It seems the flavor delete would also delete the flavor on the provider. So the above string is OK.

@mzazrivec mzazrivec self-assigned this Dec 4, 2017
@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 4, 2017
@mzazrivec mzazrivec merged commit ef7796e into ManageIQ:master Dec 4, 2017
simaishi pushed a commit that referenced this pull request Dec 4, 2017
Add delete action to flavor toolbar
(cherry picked from commit ef7796e)
@simaishi
Copy link
Contributor

simaishi commented Dec 4, 2017

Gaprindashvili backport details:

$ git log -1
commit 4e3297fb7ecbbdf37c4a19d3a07269b1987167bc
Author: Milan Zázrivec <[email protected]>
Date:   Mon Dec 4 10:38:38 2017 +0100

    Merge pull request #2900 from alexander-demichev/delete-flavor-button
    
    Add delete action to flavor toolbar
    (cherry picked from commit ef7796e6713d0778a0c24d6df197619239a37991)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants