Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean tenant names #2860

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Clean tenant names #2860

merged 1 commit into from
Dec 4, 2017

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Nov 29, 2017 •
edited
Loading

Description
Compute --> Containers --> Container Nodes -> Monitoring -> Ad-hoc metrics

Because of a change in Hawkulars API [1] we need to clean up the strings we get from the /tenant endpoint before using them.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1518538

Screenshots

Before, we have a tenants named name:hash, trying to use them will end with error 500.
screenshot-localhost 3000-2017-12-04-16-12-08

screenshot-localhost 3000-2017-12-04-16-18-37

After ( tenant names are cleaned )
screenshot-localhost 3000-2017-12-04-16-16-46

[1] https://issues.jboss.org/browse/HWKMETRICS-745

@yaacov
Copy link
Member Author

yaacov commented Nov 30, 2017 •
edited
Loading

Closing, will be fixed on Hawkular side

[EDIT] In the BZ we decided to fix than on manageiq side.

@yaacov yaacov closed this Nov 30, 2017
@yaacov yaacov changed the title [POC] Clean tenant names Clean tenant names Dec 4, 2017
@yaacov yaacov reopened this Dec 4, 2017
@yaacov
Copy link
Member Author

yaacov commented Dec 4, 2017

@miq-bot add_label compute/containers, gaprindashvili/yes

@simon3z @moolitayer @zeari @himdel @h-kataria please review

bug target 5.9

@yaacov
Copy link
Member Author

yaacov commented Dec 4, 2017

@himdel a provider with affected Hawkular for testing:
https://github.com/yaacov/miq-scripts/blob/master/set-miq-providers.rb#L81

@yaacov
Copy link
Member Author

yaacov commented Dec 4, 2017

cc @theute

@miq-bot
Copy link
Member

miq-bot commented Dec 4, 2017

Checked commit yaacov@a5ffeef with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@yaacov
Copy link
Member Author

yaacov commented Dec 4, 2017

@h-kataria please review

All the new hawkular deployments have this problem, BZ is important and high.

@himdel
Copy link
Contributor

himdel commented Dec 4, 2017

@h-kataria is on PTO this week, taking.

@himdel himdel self-assigned this Dec 4, 2017
@himdel himdel added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 4, 2017
@himdel himdel merged commit 564a9c2 into ManageIQ:master Dec 4, 2017
@himdel
Copy link
Contributor

himdel commented Dec 4, 2017

LGTM, not seeing any breakage now :)

@yaacov
Copy link
Member Author

yaacov commented Dec 4, 2017

@himdel Thanks !

simaishi pushed a commit that referenced this pull request Dec 4, 2017
@himdel @simaishi
Merge pull request #2860 from yaacov/clean-tenant-id
c81f8ba 
Clean tenant names
(cherry picked from commit 564a9c2)

https://bugzilla.redhat.com/show_bug.cgi?id=1520614
@simaishi
Copy link
Contributor

simaishi commented Dec 4, 2017

Gaprindashvili backport details:

$ git log -1
commit c81f8ba1500aa09859b29a7d72fd641307efe500
Author: Martin Hradil <[email protected]>
Date:   Mon Dec 4 16:38:28 2017 +0000

    Merge pull request #2860 from yaacov/clean-tenant-id
    
    Clean tenant names
    (cherry picked from commit 564a9c2ae301d1f3acd55ec1a111df5a764d2b04)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520614

@yaacov
Copy link
Member Author

yaacov commented Dec 7, 2017

@miq-bot fine/yes

@yaacov
Copy link
Member Author

yaacov commented Dec 7, 2017

@miq-bot add_label fine/yes

@miq-bot
Copy link
Member

miq-bot commented Dec 7, 2017

@yaacov unrecognized command 'fine', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

simaishi pushed a commit that referenced this pull request Dec 8, 2017
@himdel @simaishi
Merge pull request #2860 from yaacov/clean-tenant-id
7509349 
Clean tenant names
(cherry picked from commit 564a9c2)

https://bugzilla.redhat.com/show_bug.cgi?id=1523774
@simaishi
Copy link
Contributor

simaishi commented Dec 8, 2017

Fine backport details:

$ git log -1
commit 75093499e7321f0a90402bc05a9e7a1d4c2217b8
Author: Martin Hradil <[email protected]>
Date:   Mon Dec 4 16:38:28 2017 +0000

    Merge pull request #2860 from yaacov/clean-tenant-id
    
    Clean tenant names
    (cherry picked from commit 564a9c2ae301d1f3acd55ec1a111df5a764d2b04)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1523774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@himdel himdel

Labels
compute/containers fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaacov @miq-bot @himdel @simaishi