Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server group power ops ui #286

Merged
merged 5 commits into from
Feb 22, 2017
Merged

Server group power ops ui #286

merged 5 commits into from
Feb 22, 2017

Conversation

jkremser
Copy link
Member

@jkremser jkremser commented Feb 2, 2017 •
edited
Loading

Adding the support for power operations on middleware server groups. To save some code I reused the middleware_server_controller.js angular controller to work also with server groups.

power-ops

It depends on ManageIQ/manageiq#13741 (UPDATE: merged)

@miq-bot add_labels providers/hawkular, enhancement, pending_core

@miq-bot
Copy link
Member

miq-bot commented Feb 2, 2017

@Jiri-Kremser Cannot apply the following labels because they are not recognized: providers/hawkular, pending_core

@martinpovolny
Copy link
Member

martinpovolny commented Feb 7, 2017 •
edited
Loading

@Jiri-Kremser: moving forward we should do this throught the API rather than adding new UI controller code.
Please, do it like that in future PRs.

If any pieces would be missing for running API actions from the toolbars for example, ping me and @himdel.

@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2017

@Jiri-Kremser Cannot apply the following labels because they are not recognized: providers/hawkular, pending_core

@miq-bot
Copy link
Member

miq-bot commented Feb 10, 2017

This pull request is not mergeable. Please rebase and repush.

@jkremser
Copy link
Member Author

jkremser commented Feb 14, 2017 •
edited
Loading

It's no longer blocked by the PR ManageIQ/manageiq#13741
@miq-bot remove_labels pending core

@jkremser jkremser force-pushed the server-group-power-ops-ui branch from 7b2ad85 to ba01e0f Compare February 14, 2017 15:24
@jkremser
Copy link
Member Author

@miq-bot assign @bronaghs

@miq-bot
Copy link
Member

miq-bot commented Feb 14, 2017

@Jiri-Kremser @bronaghs is an invalid assignee, ignoring...

@bronaghs
Copy link

@Fryguy - not sure if you are the right person for this, but we need a bunch of labels and assignees made available in the manageiq-ui-classic repo, see errors above.

martinpovolny
martinpovolny reviewed Feb 17, 2017
View reviewed changes
app/assets/javascripts/controllers/middleware_server/middleware_server_controller.js Outdated

function ServerOpsServiceFactory($http, $q, isGroup) {
var runOperation = function runOperation(id, operation, timeout) {
var errorMsg = _('Error running operation on this server' + (isGroup ? '.' : ' group.'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't do math on strings that need translation. It's better to repeat the common substring rather than making the hell from the translation work ;-)

martinpovolny
martinpovolny reviewed Feb 17, 2017
View reviewed changes
app/controllers/middleware_server_controller.rb Outdated
@@ -191,7 +191,7 @@ def run_operation
operation_info = ALL_OPERATIONS.fetch(operation)
run_server_param_operation(operation_info, selected_servers)
else
msg = _("Unknown server operation: ") + operation
msg = _("Unknown server operation: ") + operation.to_s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, the preferred form would be: msg = _("Unknown server operation: %{operation}") % {:operation => operation}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's done, good catch, I missed it

@martinpovolny
Copy link
Member

aside the small i18n issues, we are good to merge!

@jkremser jkremser force-pushed the server-group-power-ops-ui branch from ba01e0f to 9086a68 Compare February 17, 2017 22:06
@miq-bot
Copy link
Member

miq-bot commented Feb 17, 2017

Checked commits jkremser/manageiq-ui-classic@21bbaf9~...9086a68 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 0 offenses detected
Everything looks good. 🍪

@jkremser
Copy link
Member Author

@martinpovolny if this is gtg, could you pls merge?

@mzazrivec mzazrivec added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 22, 2017
@martinpovolny martinpovolny merged commit e7a178a into ManageIQ:master Feb 22, 2017
@jkremser jkremser deleted the server-group-power-ops-ui branch February 22, 2017 13:44
israel-hdez added a commit to israel-hdez/manageiq-ui-classic that referenced this pull request Jan 5, 2018
@israel-hdez
Revert "Merge pull request ManageIQ#286 from Jiri-Kremser/server-grou…
41bd37d 
…p-power-ops-ui"

This reverts commit e7a178a, reversing
changes made to ce85750.
israel-hdez added a commit to israel-hdez/manageiq-ui-classic that referenced this pull request Jan 11, 2018
@israel-hdez
Revert "Merge pull request ManageIQ#286 from Jiri-Kremser/server-grou…
7d0d5f4 
…p-power-ops-ui"

This reverts commit e7a178a, reversing
changes made to ce85750.
israel-hdez added a commit to israel-hdez/manageiq-ui-classic that referenced this pull request Jan 15, 2018
@israel-hdez
Revert "Merge pull request ManageIQ#286 from Jiri-Kremser/server-grou…
48ca4ef 
…p-power-ops-ui"

This reverts commit e7a178a, reversing
changes made to ce85750.
israel-hdez added a commit to israel-hdez/manageiq-ui-classic that referenced this pull request Jan 17, 2018
@israel-hdez
Revert "Merge pull request ManageIQ#286 from Jiri-Kremser/server-grou…
d8c484d 
…p-power-ops-ui"

This reverts commit e7a178a, reversing
changes made to ce85750.
israel-hdez added a commit to israel-hdez/manageiq-ui-classic that referenced this pull request Jan 19, 2018
@israel-hdez
Revert "Merge pull request ManageIQ#286 from Jiri-Kremser/server-grou…
1162bd5 
…p-power-ops-ui"

This reverts commit e7a178a, reversing
changes made to ce85750.
israel-hdez added a commit to israel-hdez/manageiq-ui-classic that referenced this pull request Jan 22, 2018
@israel-hdez
Revert "Merge pull request ManageIQ#286 from Jiri-Kremser/server-grou…
c577ebf 
…p-power-ops-ui"

This reverts commit e7a178a, reversing
changes made to ce85750.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpovolny martinpovolny martinpovolny left review comments

Assignees

@martinpovolny martinpovolny

Labels
enhancement middleware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jkremser @miq-bot @martinpovolny @bronaghs @chessbyte @mzazrivec