Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: match_gtl_options should ignore order in :selected_records. #2854

Merged
merged 1 commit into from
Nov 29, 2017
Merged

Tests: match_gtl_options should ignore order in :selected_records. #2854

merged 1 commit into from
Nov 29, 2017

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Nov 28, 2017 •
edited
Loading

@miq-bot
Copy link
Member

miq-bot commented Nov 28, 2017

Checked commit martinpovolny@b2c1f98 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

skateman
skateman approved these changes Nov 29, 2017
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@mzazrivec mzazrivec self-assigned this Nov 29, 2017
@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Nov 29, 2017
@mzazrivec mzazrivec merged commit 9dd4d49 into ManageIQ:master Nov 29, 2017
@martinpovolny
Copy link
Member Author

@simaishi : no BZ for this one, but should go in. W/o this some tests might fail sporadicaly.

simaishi pushed a commit that referenced this pull request Nov 29, 2017
@mzazrivec @simaishi
Merge pull request #2854 from martinpovolny/report_data_selected_rand…
5f49332 
…om_order

Tests: match_gtl_options should ignore order in :selected_records.
(cherry picked from commit 9dd4d49)
@simaishi
Copy link
Contributor

@martinpovolny No BZ needed for PR that changes spec only 😄

@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 5f493329e2afe1e01d8af4c4805bdba91b8d551d
Author: Milan Zázrivec <[email protected]>
Date:   Wed Nov 29 10:46:31 2017 +0100

    Merge pull request #2854 from martinpovolny/report_data_selected_random_order
    
    Tests: match_gtl_options should ignore order in :selected_records.
    (cherry picked from commit 9dd4d49004c4487b2a7df936d7c2c945fe127059)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@mzazrivec mzazrivec

Labels
bug/sporadic test failure gaprindashvili/backported gtls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinpovolny @miq-bot @simaishi @skateman @mzazrivec