Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag expression fix for group editor #2845

Merged
merged 2 commits into from
Nov 28, 2017
Merged

Tag expression fix for group editor #2845

merged 2 commits into from
Nov 28, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Nov 27, 2017 •
edited
Loading

Initialize the tags_tree and @group when switching between tabs on group editor.

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1501346

Steps for Testing/QA

  1. Navigate to add group page
  2. Switch to 'Tag based on expression' on 'My company Tags'
  3. Select 'Host & Cluster' tab
  4. Select 'My company Tags'
  5. Switch tag filter to 'Specific Tags'

@miq-bot miq-bot added the wip label Nov 27, 2017
@lgalis lgalis force-pushed the group_editor_tag_tree_initialization_fix branch 2 times, most recently from f23e760 to 3a7bb37 Compare November 28, 2017 17:11
@lgalis lgalis force-pushed the group_editor_tag_tree_initialization_fix branch from 3a7bb37 to b7ea1cf Compare November 28, 2017 19:06
@lgalis lgalis changed the title [WIP] Tag expression fix for group editor Tag expression fix for group editor Nov 28, 2017
@miq-bot miq-bot removed the wip label Nov 28, 2017
@lgalis lgalis force-pushed the group_editor_tag_tree_initialization_fix branch from b7ea1cf to 7b111b8 Compare November 28, 2017 19:15
@lgalis
Copy link
Contributor Author

lgalis commented Nov 28, 2017

@miq-bot add_label bug, gaprindashvili/yes

@lgalis lgalis force-pushed the group_editor_tag_tree_initialization_fix branch from 7b111b8 to b8789d6 Compare November 28, 2017 19:17
@miq-bot
Copy link
Member

miq-bot commented Nov 28, 2017

Checked commits lgalis/manageiq-ui-classic@c7d55e0~...b8789d6 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@h-kataria
Copy link
Contributor

looks good.

@h-kataria h-kataria added this to the Sprint 75 Ending Dec 11, 2017 milestone Nov 28, 2017
@h-kataria h-kataria merged commit 477a5e8 into ManageIQ:master Nov 28, 2017
@lgalis lgalis deleted the group_editor_tag_tree_initialization_fix branch November 29, 2017 05:10
simaishi pushed a commit that referenced this pull request Nov 29, 2017
@h-kataria @simaishi
Merge pull request #2845 from lgalis/group_editor_tag_tree_initializa…
057a031 
…tion_fix

Tag expression fix for group editor
(cherry picked from commit 477a5e8)

https://bugzilla.redhat.com/show_bug.cgi?id=1518740
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 057a031a075332026b24e75a093131318c31e78f
Author: Harpreet Kataria <[email protected]>
Date:   Tue Nov 28 17:10:40 2017 -0500

    Merge pull request #2845 from lgalis/group_editor_tag_tree_initialization_fix
    
    Tag expression fix for group editor
    (cherry picked from commit 477a5e8dcef62ce4569f7ef43ec0a0612796b28b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
bug gaprindashvili/backported settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lgalis @miq-bot @h-kataria @simaishi @dclarizio