Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render flash when running compliance check for a container node 🐞 #2841

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

skateman
Copy link
Member

We were rendering a blank page after the compliance check for a container node has been initiated. This PR forces the flash rendering as there's always a positive/negative message to be displayed.

https://bugzilla.redhat.com/show_bug.cgi?id=1516864

@miq-bot
Copy link
Member

miq-bot commented Nov 27, 2017

Checked commit skateman@9a7a01f with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

spec/controllers/container_node_controller_spec.rb

@mzazrivec mzazrivec self-assigned this Nov 28, 2017
@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Nov 28, 2017
@mzazrivec mzazrivec merged commit 2566672 into ManageIQ:master Nov 28, 2017
@skateman skateman deleted the container-node-flash branch November 28, 2017 10:11
simaishi pushed a commit that referenced this pull request Nov 28, 2017
Render flash when running compliance check for a container node 🐞
(cherry picked from commit 2566672)

https://bugzilla.redhat.com/show_bug.cgi?id=1518332
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 99e1b1aaabd8f4a9ab5d0c77d068321cadea3783
Author: Milan Zázrivec <[email protected]>
Date:   Tue Nov 28 10:58:22 2017 +0100

    Merge pull request #2841 from skateman/container-node-flash
    
    Render flash when running compliance check for a container node <U+1F41E>
    (cherry picked from commit 2566672ba22c3f4e59369b87ddcb4a03940efa52)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants