Use record instead of ems instance var in textual authentication status

[skateman]

Somehow the container PDF report summary generation is different from the other screens. I'm not sure about the fix, @martinpovolny could you please check?

https://bugzilla.redhat.com/show_bug.cgi?id=1516710

[martinpovolny]

Generally we want to use @record for the textual summaries so I like the fix.

Question arrise about why the @ems was there. Was that leftover or is this code used in some place where @ems and @record differ?

[skateman]

@martinpovolny the only thing I found was something like @ems = @record = .... Not sure why do we have it here. Checked this on similar pages and the @record has been used everywhere.

[martinpovolny]

Ok. Please, write a simple spec that will call the stuff used for PDF generation and will reach this method. Thx!

[skateman]

@martinpovolny the PDF generation is not available in the testing environment and mocking the generator would just make the test meaningless. Do you have any ideas?

[martinpovolny]

Well the PDF generator is fed with some HTML. So just call that HTML rendering the way it's called when the PDF is generated and assert on top of that HTML. Does that make sense?

[martinpovolny]

:exclamation: - Line 256, Col 7 - Rails/HttpPositionalArguments - Use keyword arguments instead of positional arguments for http call: get.

this?

[miq-bot]

Checked commit skateman@a6f3450 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

app/helpers/textual_mixins/textual_authentications_status.rb

• ❗ - Line 43, Col 5 - Style/MultilineIfModifier - Favor a normal if-statement over a modifier clause in a multiline statement.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit b3b454801f965934555d0da6270b02dd14c9ee49
Author: Martin Povolny <[email protected]>
Date:   Mon Dec 4 14:53:55 2017 +0100

    Merge pull request #2823 from skateman/container-pdf-report
    
    Use record instead of ems instance var in textual authentication status
    (cherry picked from commit f83b8f6ba930f38d51fb83ff12a1af12b1fd61a1)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520531