Add @targets_hash as another source of records for GTL. #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's still one more way to specify records for the GTL grid to display -- @targets_hash. Adding that + specs for /host/edit. https://bugzilla.redhat.com/show_bug.cgi?id=1515725
martinpovolny
force-pushed
the
targets_hash_gtl
branch
from
01712bd to
cbcb6d5
Compare
|
Some comments on commit martinpovolny@cbcb6d5 spec/controllers/host_controller_spec.rb
|
|
Checked commit martinpovolny@cbcb6d5 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@karelhala, @mzazrivec, @himdel : please, review this in detail. I probably need more rest. Just merged my own PR :-( |
|
Tested, looks good, including the tests. |
|
LGTM as well :) |
|
Looks solid, I like that we are slowly adding tests to these areas. |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
Add @targets_hash as another source of records for GTL. (cherry picked from commit ec7d7dd) https://bugzilla.redhat.com/show_bug.cgi?id=1517939
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still one more way to specify records for the GTL grid to
display -- @targets_hash. Adding that + specs for /host/edit.
https://bugzilla.redhat.com/show_bug.cgi?id=1515725