Make /report_data protect @lastaction. Fix "No items were selected for XXXXX" #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1514334 Add lastaction to ReportDataAdditionalOptions to fix retiring VMs in Compute -> Infrastructure -> Virtual Machines.
|
@miq-bot add_label bug, gaprindashvili/yes |
martinpovolny
changed the title
martinpovolny
changed the title
Add a spec test to check if @lastaction is set, for proper rendering the explorer.
hstastna
force-pushed
the
Cannot_retire_VM
branch
from
1288a08 to
50bbe7f
Compare
|
Some comments on commits hstastna/manageiq-ui-classic@736d0df~...50bbe7f spec/controllers/vm_infra_controller_spec.rb
|
|
Checked commits hstastna/manageiq-ui-classic@736d0df~...50bbe7f with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
This PR was green before a while. @hstastna fixed a whitespace issue but meanwhile master was broken. The fail is unrelated --> Merging this PR anyway. |
Closed
|
@simaishi can be this backported to Gaprindashvili? It fixes a lot of bugs so it would be good to do it asap. Thanks a lot! |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
Make /report_data protect @lastaction. Fix "No items were selected for XXXXX" (cherry picked from commit e55eea0) https://bugzilla.redhat.com/show_bug.cgi?id=1517842
|
Gaprindashvili backport details: |
|
@miq-bot add_label test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@lastactionis lost in/report_datadue to a regression in#2669
GTL should pass last action and last action should stay unchanged through the /report_data request.
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1514334
Before:
After:
