Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tagging issus for Configuration Management Providers and Configured Systems #2781

Merged
merged 3 commits into from
Nov 21, 2017
Merged

Fix tagging issus for Configuration Management Providers and Configured Systems #2781

merged 3 commits into from
Nov 21, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Nov 20, 2017 •
edited
Loading

  • Use the corresponding model according to the node selected when tagging
  • Remove the tagging menu item for the Configuration Profiles list
  • Specs

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1512116

Steps for Testing/QA

  1. Add a Foreman provider, refresh
  2. Select a Manager and a Configuration Profile
  3. Select a configured system by checking it from either the list in the Configuration Profile or from it's summary page and tryy tagging

@lgalis lgalis changed the title Fix tagging issus for Configuration Management Providers and Configured Systems [WIP] Fix tagging issus for Configuration Management Providers and Configured Systems Nov 20, 2017
@miq-bot miq-bot added the wip label Nov 20, 2017
@lgalis lgalis force-pushed the tagging_based_on_node_type_foreman_provider branch from 32b697e to a620bab Compare November 20, 2017 21:17
@lgalis lgalis force-pushed the tagging_based_on_node_type_foreman_provider branch from a620bab to 74c4300 Compare November 20, 2017 21:21
@lgalis lgalis force-pushed the tagging_based_on_node_type_foreman_provider branch from 74c4300 to 9911686 Compare November 20, 2017 21:36
@miq-bot
Copy link
Member

miq-bot commented Nov 20, 2017

Checked commits lgalis/manageiq-ui-classic@71e81cf~...59e8b03 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐

@lgalis lgalis changed the title [WIP] Fix tagging issus for Configuration Management Providers and Configured Systems Fix tagging issus for Configuration Management Providers and Configured Systems Nov 21, 2017
@miq-bot miq-bot removed the wip label Nov 21, 2017
@h-kataria h-kataria added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 21, 2017
@h-kataria h-kataria merged commit 79529dc into ManageIQ:master Nov 21, 2017
@lgalis lgalis deleted the tagging_based_on_node_type_foreman_provider branch November 22, 2017 04:05
simaishi pushed a commit that referenced this pull request Nov 27, 2017
@h-kataria @simaishi
Merge pull request #2781 from lgalis/tagging_based_on_node_type_forem…
d6906ca 
…an_provider

Fix tagging issus for Configuration Management Providers and Configured Systems
(cherry picked from commit 79529dc)

https://bugzilla.redhat.com/show_bug.cgi?id=1517894
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit d6906cac1e7e658b92368469c15ee97c575a0dc6
Author: Harpreet Kataria <[email protected]>
Date:   Tue Nov 21 18:44:44 2017 -0500

    Merge pull request #2781 from lgalis/tagging_based_on_node_type_foreman_provider
    
    Fix tagging issus for Configuration Management Providers and Configured Systems
    (cherry picked from commit 79529dcb80273c7d9b6ee5cfd8e6396e268cb23c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AparnaKarve AparnaKarve Awaiting requested review from AparnaKarve

Assignees

@h-kataria h-kataria

Labels
bug configuration management gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lgalis @miq-bot @simaishi @dclarizio @h-kataria