Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TenantComponent - don't error modal on validation errors #2778

Merged
merged 2 commits into from
Dec 5, 2017
Merged

TenantComponent - don't error modal on validation errors #2778

merged 2 commits into from
Dec 5, 2017

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Nov 20, 2017

user > Configuration > Access Control - Tenant - add a new tenant with a duplicate name

Don't show the error modal on validation errors - this time in TenantComponent.

https://bugzilla.redhat.com/show_bug.cgi?id=1507852

@miq-bot
Copy link
Member

miq-bot commented Nov 28, 2017

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/2a340bce352bd25fcee7bf0acb5fa61a3a4afbff~...db7d7b530d2177d2bff7e385511e53a73b987d04 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Dec 5, 2017
@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 5, 2017
@mzazrivec mzazrivec merged commit 936067f into ManageIQ:master Dec 5, 2017
simaishi pushed a commit that referenced this pull request Dec 5, 2017
TenantComponent - don't error modal on validation errors
(cherry picked from commit 936067f)

https://bugzilla.redhat.com/show_bug.cgi?id=1520970
@simaishi
Copy link
Contributor

simaishi commented Dec 5, 2017

Gaprindashvili backport details:

$ git log -1
commit 1de3065135f35156605989a2c922ad3749899d37
Author: Milan Zázrivec <[email protected]>
Date:   Tue Dec 5 09:58:05 2017 +0100

    Merge pull request #2778 from himdel/ops-validate-bz1507852
    
    TenantComponent - don't error modal on validation errors
    (cherry picked from commit 936067fbcdabcbc2bb74c1fba8a32438426843e2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520970

@himdel himdel deleted the ops-validate-bz1507852 branch December 5, 2017 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants