Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed harmless missing CSS error in WebMKS remote consoles #2767

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Fixed harmless missing CSS error in WebMKS remote consoles #2767

merged 1 commit into from
Nov 20, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Nov 20, 2017 •
edited
Loading

Regression caused by #2662 FYI @bmclaughlin, it shows a 404 for a missing CSS file when opening a WebMKS console.

https://bugzilla.redhat.com/show_bug.cgi?id=1490640

@miq-bot
Copy link
Member

miq-bot commented Nov 20, 2017

Checked commit skateman@a45648f with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Nov 20, 2017
@mzazrivec mzazrivec added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 20, 2017
@mzazrivec mzazrivec merged commit a106745 into ManageIQ:master Nov 20, 2017
@skateman skateman deleted the webmks-css-harmless branch November 20, 2017 11:24
@bmclaughlin
Copy link
Contributor

@skateman thanks!

simaishi pushed a commit that referenced this pull request Nov 20, 2017
@mzazrivec @simaishi
Merge pull request #2767 from skateman/webmks-css-harmless
21d637e 
Fixed harmless missing CSS error in WebMKS remote consoles
(cherry picked from commit a106745)

https://bugzilla.redhat.com/show_bug.cgi?id=1515415
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 21d637e7135572a345c42179755c623d2a18f332
Author: Milan Zázrivec <[email protected]>
Date:   Mon Nov 20 12:09:15 2017 +0100

    Merge pull request #2767 from skateman/webmks-css-harmless
    
    Fixed harmless missing CSS error in WebMKS remote consoles
    (cherry picked from commit a106745c66349e500ec6984eee19df396e830f0b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1515415

simaishi pushed a commit that referenced this pull request Nov 28, 2017
@mzazrivec @simaishi
Merge pull request #2767 from skateman/webmks-css-harmless
dd192c3 
Fixed harmless missing CSS error in WebMKS remote consoles
(cherry picked from commit a106745)

https://bugzilla.redhat.com/show_bug.cgi?id=1515416
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit dd192c3040557272cb88f9b34a14e4a2c0712a3d
Author: Milan Zázrivec <[email protected]>
Date:   Mon Nov 20 12:09:15 2017 +0100

    Merge pull request #2767 from skateman/webmks-css-harmless
    
    Fixed harmless missing CSS error in WebMKS remote consoles
    (cherry picked from commit a106745c66349e500ec6984eee19df396e830f0b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1515416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug consoles fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skateman @miq-bot @bmclaughlin @simaishi @mzazrivec