Fix statement in flash message #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chessbyte
reviewed
Nov 21, 2017
| @@ -236,7 +236,7 @@ def cu_repair_field_changed | |||
| def cu_repair | |||
| return unless load_edit("curepair_edit__new", "replace_cell__explorer") | |||
| if @edit[:new][:end_date].to_time < @edit[:new][:start_date].to_time | |||
| add_flash(_("End Date cannot be greater than Start Date"), :error) | |||
| add_flash(_("End Date cannot be smaller than Start Date"), :error) | |||
There was a problem hiding this comment.
Suggest earlier instead of smaller
There was a problem hiding this comment.
Fixed as suggested, thanks.
mzazrivec
force-pushed
the
fix_flash_message_statement
branch
from
a558401 to
191407c
Compare
|
Checked commit mzazrivec@191407c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
Fix statement in flash message (cherry picked from commit 93fcae5)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition for showing the problematic flash message: