Fix show record after generic object custom button dialog run #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, gaprindashvili/yes |
lgalis
force-pushed
the
cb_dialog_run_return_to_nested_list
branch
2 times, most recently
from
0c31516 to
47deff5
Compare
lgalis
changed the title
lgalis
changed the title
lgalis
changed the title
lgalis
changed the title
lgalis
changed the title
|
@lgalis can you add before/after screenshots |
|
This pull request is not mergeable. Please rebase and repush. |
lgalis
force-pushed
the
cb_dialog_run_return_to_nested_list
branch
from
47deff5 to
78b7d14
Compare
lgalis
changed the title
|
Setting back to WIP to fix a new issue I see on master when running the CB dialog. |
lgalis
force-pushed
the
cb_dialog_run_return_to_nested_list
branch
4 times, most recently
from
80947a4 to
8c3fecd
Compare
lgalis
changed the title
martinpovolny
changed the title
lgalis
force-pushed
the
cb_dialog_run_return_to_nested_list
branch
2 times, most recently
from
cf1d685 to
c4fa865
Compare
lgalis
changed the title
|
@martinpovolny, @h-kataria - please review |
Merge branch 'master' of github.com:ManageIQ/manageiq-ui-classic into cb_dialog_run_return_to_nested_list
lgalis
force-pushed
the
cb_dialog_run_return_to_nested_list
branch
from
c4fa865 to
00c076a
Compare
lgalis
force-pushed
the
cb_dialog_run_return_to_nested_list
branch
from
00c076a to
a171d82
Compare
h-kataria
reviewed
Jan 3, 2018
| toolbar | ||
| end | ||
|
|
||
| def custom_button_add_related_buttons(model, record, toolbar) | ||
| # For Service, we include buttons for ServiceTemplate. | ||
| # These buttons are added as a single group with multiple buttons | ||
| if record.present? |
There was a problem hiding this comment.
@lgalis do we need this check, i see record being passed in from the caller
There was a problem hiding this comment.
yes, record may not always be present
|
Checked commits lgalis/manageiq-ui-classic@25cc68b~...53ec477 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 4, 2018
Fix show record after generic object custom button dialog run (cherry picked from commit e558369) https://bugzilla.redhat.com/show_bug.cgi?id=1531311
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service title is incorrect after running a generic object custom button with a dialog from the service generic object summary page.
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1512984
Before - errors when cancelling or submitting a dialog for a custom button
After: