Networks > Networks - fix uninitialized constant and render :change #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt in UI Networks > Networks would fail with `uninitialized constant ...CloudNetworkNew::EmsNetwork
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/851376f619a773d58a2923ea578e7ded40e3e3f0~...b754079f7fd2e68c5bdb799ad1199e540a0f2fff with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 15, 2017
Networks > Networks - fix uninitialized constant and render :change (cherry picked from commit 538e9c4)
|
Gaprindashvili backport details: |
|
@himdel, thanks for the update, actually the new/edit consolidation is going to go away (be reversed) with controller to component migration, but that's okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go to Networks > Networks
this fixes the
uninitalized constant .....CloudNetworkNew::EmsNetworkon the show_list screen.Click Configure > Add / Edit
this makes the transition use a more idiomatic
render :action => 'change'as opposed torender :change(which does the same thing; introduced in #1955).Cc @gildub
Ping @martinpovolny