Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chart_click_data handling for drill-through in /report_data. #2705

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Fix chart_click_data handling for drill-through in /report_data. #2705

merged 1 commit into from
Nov 13, 2017

Conversation

martinpovolny
Copy link
Member

romanblanco
romanblanco approved these changes Nov 13, 2017
View reviewed changes
Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, fixed the issue 👍

@himdel himdel self-assigned this Nov 13, 2017
@himdel himdel merged commit 7962e85 into ManageIQ:master Nov 13, 2017
@himdel himdel added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 13, 2017
@chessbyte
Copy link
Member

@himdel @martinpovolny @ohadlevy glad that @romanblanco tested this manually. Wondering if we can start adding tests for such non-trivial code changes

@martinpovolny martinpovolny mentioned this pull request Nov 14, 2017
Closed
simaishi pushed a commit that referenced this pull request Nov 15, 2017
@himdel @simaishi
Merge pull request #2705 from martinpovolny/chart_click_parse_roman
cef1339 
Fix chart_click_data handling for drill-through in /report_data.
(cherry picked from commit 7962e85)

https://bugzilla.redhat.com/show_bug.cgi?id=1513249
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

 $ git log -1
commit cef1339925c5bf9ac1a385ba7f712a6c30991f61
Author: Martin Hradil <[email protected]>
Date:   Mon Nov 13 13:58:44 2017 +0000

    Merge pull request #2705 from martinpovolny/chart_click_parse_roman
    
    Fix chart_click_data handling for drill-through in /report_data.
    (cherry picked from commit 7962e858e0883a8b368145e22bb4fe12296176c6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1513249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanblanco romanblanco romanblanco approved these changes

Assignees

@himdel himdel

Labels
bug charts gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinpovolny @chessbyte @simaishi @romanblanco @himdel