Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cut-off dropdowns on Tag Edit screen #2696

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Fix cut-off dropdowns on Tag Edit screen #2696

merged 1 commit into from
Nov 10, 2017

Conversation

epwinchell
Copy link
Contributor

This PR fixes a problem where the bootstrap-select dropdowns were conflicting with the GTL #main_div by setting the data-container to "body."

https://bugzilla.redhat.com/show_bug.cgi?id=1509083

Old
screen shot 2017-11-10 at 12 08 56 pm

New
screen shot 2017-11-10 at 10 16 38 am

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, formatting/styling, gaprindashvili/yes

@epwinchell
Copy link
Contributor Author

@miq-bot assign @dclarizio

@miq-bot
Copy link
Member

miq-bot commented Nov 10, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/57b855a8a65403a477d4b37ca90c0d1735bae778 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@dclarizio dclarizio merged commit cbe31ec into ManageIQ:master Nov 10, 2017
@dclarizio dclarizio added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 10, 2017
simaishi pushed a commit that referenced this pull request Nov 15, 2017
Fix cut-off dropdowns on Tag Edit screen
(cherry picked from commit cbe31ec)

https://bugzilla.redhat.com/show_bug.cgi?id=1513125
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 730fe8cf53670e201a61fa5240241698c1051ee2
Author: Dan Clarizio <[email protected]>
Date:   Fri Nov 10 10:25:55 2017 -0800

    Merge pull request #2696 from epwinchell/1509083
    
    Fix cut-off dropdowns on Tag Edit screen
    (cherry picked from commit cbe31ecc37113e1e0aba6b9ff16f49c40a5f7239)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1513125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants