Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List Provisioned disk name as N/A if size_on_disk is not collected #2681

Merged
merged 1 commit into from
Nov 9, 2017
Merged

List Provisioned disk name as N/A if size_on_disk is not collected #2681

merged 1 commit into from
Nov 9, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Nov 9, 2017

Follow up for #2673

  • list the used/porovisioned space on the disk name as N/A if not collected

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1510177

Steps for Testing/QA

Steps to Reproduce:

  1. Add an Azure provider
  2. Select any instance
  3. Click on Containers
  4. View the details of a disk
  5. Percent Used Provisioned Space: 0.0%

Before:
screenshot from 2017-11-08 12-03-35

After:
screenshot from 2017-11-09 09-00-40

@lgalis
Copy link
Contributor Author

lgalis commented Nov 9, 2017

@miq-bot add_label bug, fine/yes, gaprindashvili/yes

@dclarizio, @bronaghs - updated the disk name again after the comments in the BZ

@lgalis lgalis changed the title List Provisioned disk name as N/A if size_on_disk is not collected [WIP]List Provisioned disk name as N/A if size_on_disk is not collected Nov 9, 2017
@lgalis lgalis force-pushed the azure_disk_name_provisioned_size_na branch from 96525c7 to 492ede7 Compare November 9, 2017 15:13
@miq-bot miq-bot added the wip label Nov 9, 2017
@miq-bot
Copy link
Member

miq-bot commented Nov 9, 2017

Checked commit lgalis@492ede7 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@lgalis lgalis changed the title [WIP]List Provisioned disk name as N/A if size_on_disk is not collected List Provisioned disk name as N/A if size_on_disk is not collected Nov 9, 2017
@miq-bot miq-bot removed the wip label Nov 9, 2017
@dclarizio dclarizio merged commit fce270e into ManageIQ:master Nov 9, 2017
@dclarizio dclarizio self-assigned this Nov 9, 2017
@dclarizio dclarizio added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 9, 2017
@lgalis lgalis deleted the azure_disk_name_provisioned_size_na branch November 9, 2017 20:46
simaishi pushed a commit that referenced this pull request Nov 15, 2017
@simaishi
Merge pull request #2681 from lgalis/azure_disk_name_provisioned_size_na
f857c85 
List Provisioned disk name as N/A if size_on_disk is not collected
(cherry picked from commit fce270e)

https://bugzilla.redhat.com/show_bug.cgi?id=1511978
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit f857c850c507ebe87476f5aee433e13dd0ae0cf7
Author: Dan Clarizio <[email protected]>
Date:   Thu Nov 9 12:45:25 2017 -0800

    Merge pull request #2681 from lgalis/azure_disk_name_provisioned_size_na
    
    List Provisioned disk name as N/A if size_on_disk is not collected
    (cherry picked from commit fce270e388d2f51cf565507b93e36232e3847b14)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1511978

@simaishi simaishi mentioned this pull request Nov 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgalis @miq-bot @simaishi @dclarizio