Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Provider Conditions" title in tree builder conditions #268

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Fix "Provider Conditions" title in tree builder conditions #268

merged 1 commit into from
Jan 31, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Jan 29, 2017 •
edited by miq-bot
Loading

@zakiva
Copy link
Contributor Author

zakiva commented Jan 29, 2017

@miq-bot add_label providers/containers, bug, ui

@miq-bot
Copy link
Member

miq-bot commented Jan 29, 2017

Checked commit zakiva@3b1e704 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. ⭐

@zakiva
Copy link
Contributor Author

zakiva commented Jan 29, 2017

@h-kataria Can you please review this fix?
I saw your comment in the BZ regarding "All Node Conditions" title in the right cell (and not "All Container Node Conditions" ?) but it seems to be a different issue, this title is coming from ui_lookup so we'll probably have to change en.yml to fix that.
cc @simon3z

@simon3z
Copy link
Contributor

simon3z commented Jan 30, 2017

LGTM 👍
cc @dclarizio @h-kataria

@miq-bot assign dclarizio

@dclarizio dclarizio merged commit 0c8f61c into ManageIQ:master Jan 31, 2017
@dclarizio dclarizio added this to the Sprint 54 Ending Feb 13, 2017 milestone Jan 31, 2017
@simaishi
Copy link
Contributor

simaishi commented Mar 3, 2017

Euwe backport (to manageiq repo) details:

$ git log -1
commit 06ebc4e03fc364d22446f8492bdacaef7e04da9c
Author: Dan Clarizio <[email protected]>
Date:   Tue Jan 31 15:39:35 2017 -0800

    Merge pull request #268 from zakiva/fix_conditions_title
    
    Fix "Provider Conditions" title in tree builder conditions
    (cherry picked from commit 0c8f61c55c766ce80a282af38577e7fa75a3a676)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1418815

@miq-bot
Copy link
Member

miq-bot commented Mar 3, 2017

@zakiva Cannot apply the following label because they are not recognized: providers/containers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
bug compute/containers euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zakiva @miq-bot @simon3z @simaishi @dclarizio @mzazrivec