Amazon Docker Creds Visibility Based on Setting #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visibility of the Amazon Docker Creds tab will be based on a true Settings value. The setting used is Settings.ems.ems_amazon.agent_coordinator.docker_login_required. If the value is false no tab is presented. This feature is implemented based on offline discussions around the original PR implementing the tab - ManageIQ#2525 with @Fryguy. This is the original desired functionality but it was not implemented in time for the 4.6 cutoff.
Remove redundant curly braces around hash parameter per Rubocop.
|
Checked commits jerryk55/manageiq-ui-classic@83e58f3~...c7242ea with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@mzazrivec this is not a bug - it was an unimplemented feature. Removing the bug label. |
|
@miq-bot remove_label bug |
|
Gah, please don't @mention me in future commits...thanks! |
|
Sorry. :-(
…On Mon, Nov 13, 2017 at 3:41 PM, Jason Frey ***@***.***> wrote:
Gah, please don't @mention me in future commits...thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2666 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF1cZyI1KykGleKcM9Lncd5tUsk9fxX3ks5s2KlqgaJpZM4QWcfZ>
.
--
JERRY KESELMAN
PRINCIPAL SOFTWARE ENGINEER,
CLOUDFORMS VM SMARTSTATE ANALYSIS & STORAGE
Red Hat Inc. <https://www.redhat.com/>
[email protected]
Gitter: jerryk55
IRC: jerrykbiker
|
simaishi
pushed a commit
that referenced
this pull request
Nov 15, 2017
Amazon Docker Creds Visibility Based on Setting (cherry picked from commit f8e876b)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visibility of the Amazon Docker Creds tab will be based on a true
Settings value. The setting used is Settings.ems.ems_amazon.agent_coordinator.docker_login_required.
If the value is false no tab is presented.
This feature is implemented based on offline discussions around the original PR implementing
the tab - #2525 with @Fryguy.
This is the original desired functionality but it was not implemented in time for the 4.6 cutoff.
@AparnaKarve @h-kataria please review and merge this simple change. Thanks.
Steps for Testing/QA
In the UI go to Configuration -> Advanced and search for "docker_login_required".
Set it to false if it is not already set to that. Save.
Add an Amazon Cloud Provider. You should see the form to enter Default Credentials but
nothing for the Docker Credentials.
Now go to the Configuration and change "docker_login_required" to true and save.
Add an Amazon Cloud Provider. In addition to the Default Credentials tab you should see the
"SmartState Docker" tab.