Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reset button on Edit Button Group page #2659

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

hstastna
Copy link

@hstastna hstastna commented Nov 7, 2017

fixing https://bugzilla.redhat.com/show_bug.cgi?id=1486649

Fix Reset button when editing a Button Group in Automation -> Automate -> Customization -> Buttons tab.

The problem was wrong nodetype in group_button_reset method. We want to reset Button Group, not a button nor anything else.

reset1

Before:

, [2017-11-07T19:17:07.574795 #25832]  INFO -- : Started POST "/miq_ae_customization/group_update/1000000000041?button=reset" for ::1 at 2017-11-07 19:17:07 +0100
I, [2017-11-07T19:17:07.595585 #25832]  INFO -- : Processing by MiqAeCustomizationController#group_update as JS
I, [2017-11-07T19:17:07.595689 #25832]  INFO -- :   Parameters: {"button"=>"reset", "id"=>"1000000000041"}
I, [2017-11-07T19:17:07.631769 #25832]  INFO -- :   Rendered /home/hstastna/manageiq/manageiq-ui-classic/app/views/layouts/_flash_msg.html.haml (0.0ms)
I, [2017-11-07T19:17:07.657902 #25832]  INFO -- :   Rendered /home/hstastna/manageiq/manageiq-ui-classic/app/views/shared/_playbook_options.html.haml (8.3ms)
I, [2017-11-07T19:17:07.658024 #25832]  INFO -- :   Rendered /home/hstastna/manageiq/manageiq-ui-classic/app/views/shared/buttons/_ab_options_form.html.haml (23.2ms)
I, [2017-11-07T19:17:07.658095 #25832]  INFO -- :   Rendered /home/hstastna/manageiq/manageiq-ui-classic/app/views/shared/buttons/_ab_form.html.haml (32.8ms)
F, [2017-11-07T19:17:07.658257 #25832] FATAL -- : Error caught: [ActionView::Template::Error] no implicit conversion of nil into Array
/home/hstastna/manageiq/manageiq-ui-classic/app/views/shared/_playbook_options.html.haml:8:in `+'
/home/hstastna/manageiq/manageiq-ui-classic/app/views/shared/_playbook_options.html.haml:8:in `__home_hstastna_manageiq_manageiq_ui_classic_app_views_shared__playbook_options_html_haml___3899560385906568952_70135775787060'

After:
reset2

fixing https://bugzilla.redhat.com/show_bug.cgi?id=1486649

Fix Reset button when editing a Button Group in Automation ->
-> Automate -> Customization -> Buttons tab.
@hstastna
Copy link
Author

hstastna commented Nov 7, 2017

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Nov 7, 2017
@miq-bot
Copy link
Member

miq-bot commented Nov 7, 2017

Checked commit hstastna@1a07f8d with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec self-assigned this Nov 9, 2017
@mzazrivec mzazrivec added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 9, 2017
@mzazrivec mzazrivec merged commit 08dabe7 into ManageIQ:master Nov 9, 2017
simaishi pushed a commit that referenced this pull request Nov 15, 2017
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 4cd25e8303af62055eb86458ce4abfde69795698
Author: Milan Zázrivec <[email protected]>
Date:   Thu Nov 9 11:04:25 2017 +0100

    Merge pull request #2659 from hstastna/Edit_button_group_reset
    
    Fix Reset button on Edit Button Group page
    (cherry picked from commit 08dabe7b7f5c902f1ee8922fee0819437dffd07e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1511518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants