Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verification credential param for google #2647

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Add verification credential param for google #2647

merged 1 commit into from
Nov 7, 2017

Conversation

tumido
Copy link
Member

@tumido tumido commented Nov 6, 2017 •
edited
Loading

This change allow proper credentials verification on Google provider.

Depends on: ManageIQ/manageiq-providers-google#28

@tumido tumido mentioned this pull request Nov 6, 2017
Merged
@tumido
Copy link
Member Author

tumido commented Nov 6, 2017

cc @jntullo

@miq-bot
Copy link
Member

miq-bot commented Nov 6, 2017

Checked commit tumido@6c543ec with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@blomquisg
Copy link
Member

Back end PR is merged

@h-kataria h-kataria self-assigned this Nov 7, 2017
@h-kataria h-kataria added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 7, 2017
@h-kataria h-kataria merged commit 61cf250 into ManageIQ:master Nov 7, 2017
simaishi pushed a commit that referenced this pull request Nov 7, 2017
@h-kataria @simaishi
Merge pull request #2647 from tumido/add_verify_cred_for_google
824aad5 
Add verification credential param for google
(cherry picked from commit 61cf250)
@simaishi
Copy link
Contributor

simaishi commented Nov 7, 2017

Gaprindashvili backport details:

$ git log -1
commit 824aad58d09f7466c163d25f0a1e1a49753cbb08
Author: Harpreet Kataria <[email protected]>
Date:   Tue Nov 7 11:20:47 2017 -0500

    Merge pull request #2647 from tumido/add_verify_cred_for_google
    
    Add verification credential param for google
    (cherry picked from commit 61cf25035c5fd6b05175e287169a86edfa4e9e62)

@agrare agrare mentioned this pull request Nov 14, 2017
Merged
@tumido tumido deleted the add_verify_cred_for_google branch June 26, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
bug compute/cloud gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tumido @miq-bot @blomquisg @simaishi @h-kataria