Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Openstack InfraManager credential validation #2646

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Nov 6, 2017

This fixes the openstack platform director credential validation. The
Openstack InfraManager doesn't define an auth_url so this was raising an
exception during validation. This aligns the task arguments with the
openstack cloud manager, ref: https://github.com/agrare/manageiq-ui-classic/blob/ed4a431034499f83a05965d4e6a6cd02ba61f271/app/controllers/mixins/ems_common_angular.rb#L120-L121

This fixes the openstack platform director credential validation.  The
Openstack InfraManager doesn't define an auth_url so this was raising an
exception during validation.  This aligns the task arguments with the
openstack cloud manager.
@agrare
Copy link
Member Author

agrare commented Nov 6, 2017

@miq-bot add-label bug, gaprindashvili/yes
@miq-bot assign @Fryguy

@miq-bot
Copy link
Member

miq-bot commented Nov 6, 2017

Checked commit agrare@ed4a431 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy Fryguy merged commit 81cdc80 into ManageIQ:master Nov 6, 2017
@Fryguy Fryguy added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 6, 2017
@agrare agrare deleted the fix_openstack_infra_credential_validation branch November 6, 2017 20:43
simaishi pushed a commit that referenced this pull request Nov 7, 2017
…alidation

Fix Openstack InfraManager credential validation
(cherry picked from commit 81cdc80)
@simaishi
Copy link
Contributor

simaishi commented Nov 7, 2017

Gaprindashvili backport details:

$ git log -1
commit 7f193578850214399ac954dcc8cf19fd0b150828
Author: Jason Frey <[email protected]>
Date:   Mon Nov 6 15:08:53 2017 -0500

    Merge pull request #2646 from agrare/fix_openstack_infra_credential_validation
    
    Fix Openstack InfraManager credential validation
    (cherry picked from commit 81cdc80b6ab65340ec3e1511ea05e7c64eb21552)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants