Replace conditions with named scopes

[alexander-demicev]

Replace conditions with named scopes.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1507916

[alexander-demicev]

Related PR's: ManageIQ/manageiq#16399 ManageIQ/manageiq-providers-openstack#144

[alexander-demicev]

@martinpovolny Hi, added some tests, can you make a review?

[miq-bot]

Some comments on commits alexander-demicev/manageiq-ui-classic@5bb45cb~...887d28e

spec/controllers/host_controller_spec.rb

• ⚠️ - 217 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 233 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 249 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 265 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

[miq-bot]

Checked commits alexander-demicev/manageiq-ui-classic@5bb45cb~...887d28e with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐

[martinpovolny]

The changes look very good.

Thanks for the tests.

Can you get someone from your group test this in the UI? @aufi? @mansam?

Thx!

[martinpovolny]

Need to wait for the provider PR anyway.

[alexander-demicev]

@martinpovolny Related PR's are merged :)

[martinpovolny]

I'd love to merge this. But I don't have the data to properly test this now.

Can you get someone from your group test this in the UI? @aufi? @mansam?

Ping @aufi, @mansam, @tzumainn : can you, please, confirm this works as expected?

[mansam]

I will review this as soon as possible.

[martinpovolny]

ping @mansam?

[mansam]

@martinpovolny Looks like it's working as intended to me.