GO cleanup #2635
Merged
GO cleanup #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods that deal with a node should get the node as an argument, not from 2 different side channels. This way it's easier to follow data flow in the code and write tests.
This actually saves a lot of repetition of string operations and provides better readability.
ExplorePresenter expects a hash not a string in :activate_node. So this has no positive effect.
node_info is called only from one place and x_node is set there. Removing unneeded condition, pass data as an argument.
|
Checked commits martinpovolny/manageiq-ui-classic@af249e3~...7e515c6 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@jhernand The card is private, but judging from the title, I'm guessing this is not related to generic object definitions? |
|
@himdel yes, just bad clicking in the Trello UI, my fault. I undid it. |
|
LGTM, the only ui breakage I see (not being able to create a custom button) is present in master as well (and hopefully fixed in #2569) 👍 |
AparnaKarve
added a commit
to AparnaKarve/manageiq-ui-classic
that referenced
this pull request
Nov 6, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 7, 2017
GO cleanup (cherry picked from commit a0a1c1a)
|
Gaprindashvili backport details: |
AparnaKarve
added a commit
to AparnaKarve/manageiq-ui-classic
that referenced
this pull request
Nov 8, 2017
AparnaKarve
added a commit
to AparnaKarve/manageiq-ui-classic
that referenced
this pull request
Nov 9, 2017
AparnaKarve
added a commit
to AparnaKarve/manageiq-ui-classic
that referenced
this pull request
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick round of cleanups for the new GO code.
TODO: Other issues that I have noticed:
app/views/generic_object_definition/_show_list.html.haml-- a view that basically just contains a branching logic that should be in a controllerI think that this needs to go to the release, because we are going to see more work and fixes in this new area and we don't want to do the work twice.