Ignore empty amqp fallback hostnames #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not create incomplete amqp fallback endpoints if there are no hostnames provided via the input form.
|
@gberginc & @miha-plesko i kindly ask you to review this. |
|
Checked commit gasper-vrhovsek@8bc951c with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot add_label bug,gaprindashvili/yes Marking bug as Nuage manager got two additional endpoints even when left empty in the UI. |
gberginc
approved these changes
Nov 3, 2017
|
@miq-bot assign @h-kataria |
|
@gberginc is there BZ associated with this fix. |
|
@dclarizio changes look good to be merged, but since this PR is marked as gaprindashvili/yes it should have BZ associated with it, it can be merged once there is a BZ link added to the description of PR/commit. |
simaishi
pushed a commit
that referenced
this pull request
Dec 4, 2017
…qp_fallback_hostnames Ignore empty amqp fallback hostnames (cherry picked from commit 15a7152)
|
@h-kataria BZ will be required once we go to 'blocker' only phase. Gaprindashvili backport details: |
gasper-vrhovsek
deleted the
feature/ignore_empty_amqp_fallback_hostnames
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not create incomplete amqp fallback endpoints if there are no
hostnames provided via the input form.
@miq-bot add_label networks