[WIP] Expose Custom Buttons for Generic Objects in Service #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igalis 1. please rebase, 2. please add tests... |
|
@ohadlevy - this is WIP - not ready yet |
|
This pull request is not mergeable. Please rebase and repush. |
lgalis
force-pushed
the
expose_custom_buttons_for_generic_objects
branch
from
a6c5805 to
6137d23
Compare
lgalis
force-pushed
the
expose_custom_buttons_for_generic_objects
branch
3 times, most recently
from
2607233 to
a7e2c5d
Compare
|
This pull request is not mergeable. Please rebase and repush. |
lgalis
force-pushed
the
expose_custom_buttons_for_generic_objects
branch
from
a7e2c5d to
bc6ba0c
Compare
lgalis
force-pushed
the
expose_custom_buttons_for_generic_objects
branch
from
bc6ba0c to
8d45aa8
Compare
lgalis
force-pushed
the
expose_custom_buttons_for_generic_objects
branch
from
8d45aa8 to
2dc80d2
Compare
|
Checked commits lgalis/manageiq-ui-classic@8f8d326~...2dc80d2 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/service_controller.rb
app/helpers/application_helper/toolbar_builder.rb
|
|
Close in favor of #2636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
https://www.pivotaltracker.com/story/show/150933586