adds support to using webpack-dev-server #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
reviewed
Oct 31, 2017
config/webpack/development.js
Outdated
| secure: false | ||
| }, | ||
| '/ws': { | ||
| target: `ws://${settings.dev_server.host}`, |
There was a problem hiding this comment.
@himdel do we allow to customize the port for ws (vs wss)? is it set somewhere ?
ohadlevy
force-pushed
the
webpack-dev-server
branch
from
d364391 to
fa72f04
Compare
|
@himdel updated. |
this allow the developer to: - use websockets in development env without apache - enjoy live reload in the browser when webpack code change to use, execute: NODE_ENV=development ./node_modules/.bin/webpack-dev-server --config config/webpack/development.js you may use PORT or WS_PORT to override the default 3000 PORT.
ohadlevy
force-pushed
the
webpack-dev-server
branch
from
fa72f04 to
5b4e241
Compare
|
Checked commit ohadlevy@5b4e241 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
all 🍏 :-) |
|
This would be really great to get in soon! Current dev work with webpacks is quite slow. |
|
@himdel anything I can do to move this along? thanks! |
|
this would be exxxxcellent... 🏆 |
ohadlevy
commented
Nov 28, 2017
| }, | ||
| proxy: { | ||
| '/': { | ||
| target: `http://${settings.dev_server.host}:${env.PORT || '3000'}`, |
There was a problem hiding this comment.
is there a better ENV var name? (so that we can use with webpacker or foreman Procfile)?
|
anyone else who can merge this ? thanks :) |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allow the developer to:
to use, execute:
NODE_ENV=development ./node_modules/.bin/webpack-dev-server --config config/webpack/development.js