Dupe message when clicking Reset button in gtl page mode #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chessbyte
reviewed
Oct 19, 2017
app/views/layouts/_protect.html.haml
Outdated
| @@ -22,4 +22,5 @@ | |||
| - if @politems | |||
| - @embedded = true | |||
| - @quadicon_no_url = true | |||
| = render :partial => "layouts/gtl" | |||
| - no_flash_div = true | |||
| = render :partial => "layouts/gtl", :locals => {:no_flash_div => no_flash_div} | |||
There was a problem hiding this comment.
Would the simpler = render :partial => "layouts/gtl", :locals => {:no_flash_div => true} work?
GregP
force-pushed
the
dupe_msg_gtl_pages_reset
branch
from
cceecaa to
0cbfd05
Compare
|
Checked commit GregP@0cbfd05 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@h-kataria Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added early setting for no_flash_div, to determine page mode display, gtl or not.
https://bugzilla.redhat.com/show_bug.cgi?id=1486699
https://bugzilla.redhat.com/show_bug.cgi?id=1486674
Screen shots prior to code fix showing dupe messages displayed, top and bottom of page:
Screen shots showing just one flash message displayed, at the top of page (2 parts):