Add target_id and target_class columns to dataset defined in MiqTask.yaml #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rned dataset. Those columns will be used for drilldown from job to target VM
|
Checked commit yrudman@5e73a74 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #592 there is no navigation to VmOrTemplate screen for selected job record.
https://bugzilla.redhat.com/show_bug.cgi?id=1502578
issue: #1206
job.target_idandjob.target_classdata used to provide navigation to target object from selected Smart State Analysis linked task.This PR:
updates
MiqTask.yamlto includejobs.target_classandjobs.target_idHistory:
Those columns were already added to
MiqTask.yamlin ManageIQ/manageiq#14932 but were accidently removed in #1422. Removing went unnoticed since navigation to target was not implemented.@miq-bot add-label bug, fine/no
/cc @h-kataria @gtanzillo