Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable copy condition #2448

Merged

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Oct 18, 2017

Enables copy of policy conditions without checking RBAC.

Links [Optional]

https://bugzilla.redhat.com/show_bug.cgi?id=1498214

Screenshots

Before:
screencapture-localhost-3000-miq_policy-explorer-1508340542351
After:
screencapture-localhost-3000-miq_policy-explorer-1508340461449

@PanSpagetka PanSpagetka force-pushed the copy-oscap-policy-condition-button branch from bb16e0a to b6965a5 Compare October 18, 2017 15:25
@miq-bot
Copy link
Member

miq-bot commented Oct 18, 2017

Checked commit PanSpagetka@b6965a5 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 2 offenses detected

app/helpers/application_helper/button/condition_policy_copy.rb

app/helpers/application_helper/toolbar/condition_center.rb

@PanSpagetka PanSpagetka changed the title Enable copy of condition Enable copy condition Oct 19, 2017
@mzazrivec mzazrivec self-assigned this Oct 19, 2017
@mzazrivec mzazrivec added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 19, 2017
@mzazrivec mzazrivec merged commit b3ae7cf into ManageIQ:master Oct 19, 2017
simaishi pushed a commit that referenced this pull request Nov 20, 2017
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 17f7e6846af30a55842ab68e21451ab9bd76684b
Author: Milan Zázrivec <[email protected]>
Date:   Thu Oct 19 09:41:04 2017 +0200

    Merge pull request #2448 from PanSpagetka/copy-oscap-policy-condition-button
    
    Enable copy condition
    (cherry picked from commit b3ae7cf6263b52da19b33e6755c65b384171ee56)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1505501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants