Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app's locale when user locale preferences changed #2438

Conversation

mzazrivec
Copy link
Contributor

Configuration -> My Settings -> Locale

Previously, after saving the new user locale preferences, the page rendered afterwards
was still in the previous locale. This would change with this PR.

https://bugzilla.redhat.com/show_bug.cgi?id=1486621

@miq-bot
Copy link
Member

miq-bot commented Oct 18, 2017

Checked commit mzazrivec@2c72be1 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, fixes the issue 👍

@romanblanco
Copy link
Member

ping @martinpovolny @himdel

@martinpovolny martinpovolny merged commit 933cc32 into ManageIQ:master Oct 26, 2017
@martinpovolny martinpovolny added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 26, 2017
@mzazrivec mzazrivec deleted the update_application_locale_when_preferences_changed branch February 22, 2018 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants