Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the download_pdf button to summary view for infrastructure providers #2429

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Add the download_pdf button to summary view for infrastructure providers #2429

merged 1 commit into from
Oct 18, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Oct 17, 2017

Add the download_pdf button to summary view for infrastructure providers

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1503213

@lgalis
Copy link
Contributor Author

lgalis commented Oct 17, 2017

@miq-bot add_label bug

@lgalis lgalis changed the title Add the download_pdf button to summary view for infrastructure providers [WIP] Add the download_pdf button to summary view for infrastructure providers Oct 17, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 17, 2017

Checked commit lgalis@d3e12a4 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 2 offenses detected

app/helpers/application_helper/toolbar/dashboard_summary_toggle_view.rb

  • ❗ - Line 30, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
  • ❗ - Line 38, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.

@lgalis lgalis changed the title [WIP] Add the download_pdf button to summary view for infrastructure providers Add the download_pdf button to summary view for infrastructure providers Oct 17, 2017
@miq-bot miq-bot removed the wip label Oct 17, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Oct 17, 2017

@h-kataria - please review

@lgalis
Copy link
Contributor Author

lgalis commented Oct 17, 2017

@miq-bot add_label fine/yes, euwe/yes

@lgalis lgalis closed this Oct 17, 2017
@lgalis lgalis reopened this Oct 17, 2017
@mzazrivec mzazrivec self-assigned this Oct 18, 2017
@mzazrivec mzazrivec added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 18, 2017
@mzazrivec mzazrivec merged commit 86cc511 into ManageIQ:master Oct 18, 2017
@lgalis lgalis deleted the download_pdf_button_missing_for_infra_providers branch October 18, 2017 13:31
@simaishi
Copy link
Contributor

simaishi commented Oct 23, 2017 •
edited
Loading

Euwe backport (to manageiq repo) details:

$ git log -1
commit 8485104fc752331498d57c3f03fc6cb6a4cd044e
Author: Milan Zázrivec <[email protected]>
Date:   Wed Oct 18 10:41:38 2017 +0200

    Merge pull request #2429 from lgalis/download_pdf_button_missing_for_infra_providers
    
    Add the download_pdf button to summary view for infrastructure providers
    (cherry picked from commit 86cc511a6fe79be2b8dd23785d96c4d870b26b91)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1505458

simaishi pushed a commit that referenced this pull request Nov 20, 2017
@mzazrivec @simaishi
Merge pull request #2429 from lgalis/download_pdf_button_missing_for_…
8a4b22c 
…infra_providers

Add the download_pdf button to summary view for infrastructure providers
(cherry picked from commit 86cc511)

https://bugzilla.redhat.com/show_bug.cgi?id=1505456
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 8a4b22c78442f74ce138e4d7f9529c74d8c70958
Author: Milan Zázrivec <[email protected]>
Date:   Wed Oct 18 10:41:38 2017 +0200

    Merge pull request #2429 from lgalis/download_pdf_button_missing_for_infra_providers
    
    Add the download_pdf button to summary view for infrastructure providers
    (cherry picked from commit 86cc511a6fe79be2b8dd23785d96c4d870b26b91)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1505456

@lgalis lgalis mentioned this pull request Nov 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
blocker bug compute/infrastructure euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgalis @miq-bot @simaishi @mzazrivec