Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set formnovalidate on "create host aggregate" form's cancel button #2416

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Oct 16, 2017

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1495719 by setting formnovalidate on the cancel button of the Create Host Aggregate form.

It's possible that this might be a flag we want on cancel buttons system-wide so that clicking them never causes html5 validation popouts to appear, but I'm not sure if there are any undesirable effects to such a sweeping change.

@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2017

Checked commit mansam@61483b4 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec self-assigned this Oct 17, 2017
@mzazrivec mzazrivec added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 17, 2017
@mzazrivec mzazrivec merged commit 0b2cfce into ManageIQ:master Oct 17, 2017
simaishi pushed a commit that referenced this pull request Nov 14, 2017
Set formnovalidate on "create host aggregate" form's cancel button
(cherry picked from commit 0b2cfce)

https://bugzilla.redhat.com/show_bug.cgi?id=1511144
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 9c50e091267e478d1d61e615454b587ac636b1b7
Author: Milan Zázrivec <[email protected]>
Date:   Tue Oct 17 12:48:07 2017 +0200

    Merge pull request #2416 from mansam/hostaggregate-cancel-novalidate
    
    Set formnovalidate on "create host aggregate" form's cancel button
    (cherry picked from commit 0b2cfce48e91a8b8255cda8656087638765407cb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1511144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants