Fix wrong flash messages after widget import

[ZitaNemeckova]

Cloud Intel -> Reports -> Import/Export -> Widgets -> Choose file (yml with exported widgets) -> Upload -> no widget is checked -> Commit

Before:

No widget imported.

After:

Cloud Intel -> Reports -> Import/Export -> Widgets -> Choose file (yml with exported widgets) -> Upload -> check few widgets -> Commit

Before:

After:

https://bugzilla.redhat.com/show_bug.cgi?id=1501119

Bug is present in Fine.

@miq-bot add_label bug, fine/yes

[mzazrivec]

The whole if can be done as:

n_("%{number} widget imported successfully", "%{number} widgets imported successfully", number) % {:number => number}

[miq-bot]

Checked commits ZitaNemeckova/manageiq-ui-classic@78d375e~...155463d with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks fine. 🍪

[ZitaNemeckova]

@mzazrivec Fixed. Thanks :)

[mzazrivec]

The problem here is that this fix will work only as long as queue worker isn't running. If it's running,
the widget import (with or without fix from this PR) will fail with the following error:

This seems to be caused by the fact, that the imported file is deleted by the queue worker
before we're able to do anything with its content (see store_for_import from WidgetImportService).

I'm a bit on the edge what to do about this PR. @himdel @martinpovolny what do you guys think?

[himdel]

@mzazrivec I think we should treat it as 2 distinct bugs..

What store_for_import does is call MiqQueue.put with :deliver_on => 1.day.from_now,.

So.. there should be plenty of time :).

But apparently, the attribute is ignored because the task gets run immediately - hence I think this is 2 bugs and the second one is a backend bug => ManageIQ/manageiq#16238.

[ZitaNemeckova]

@mzazrivec ManageIQ/manageiq#16238 for that error you mentioned.

[Fryguy]

If you are seeing this happening with simulate_queue_worker, then that is by design (see my comment in ManageIQ/manageiq#16238). If you are seeing that with a "real" worker, then we have a real bug.

[simaishi]

Fine backport details:

$ git log -1
commit 7c8eb3faec2d647c62782fe71f80fd7a5bcae488
Author: Milan Zázrivec <[email protected]>
Date:   Fri Oct 20 13:18:34 2017 +0200

    Merge pull request #2411 from ZitaNemeckova/fix_widget_import
    
    Fix wrong flash messages after widget import
    (cherry picked from commit a26b01e4ad6d65b34aab64b4e4d084e7b18aafd7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1504775