Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Chargeable field for determining measure in rate editor #2407

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

lpichler
Copy link
Contributor

previously ChargebackRate(variable detail in code) model had relation to ChargebackRateDetailMeasure model. But we removed it and we relations are:
ChargebackRate -> ChargeableField -> ChargebackRateDetailMeasure

So we need to get ChargebackRateDetailMeasure from ChargeableField and it was causing that select box was disappeared.

before
screen shot 2017-10-16 at 14 39 58

after
screen shot 2017-10-16 at 14 39 11

Testing steps

  1. CI -> Chargeback -> Rates
  2. Add and edit existing rate
  3. See it there are checkboxes in per unit column.

@miq-bot assign @mzazrivec
@miq-bot add_label bug

@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2017

Checked commit lpichler@9e967cd with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 17, 2017
@mzazrivec mzazrivec merged commit 2e04349 into ManageIQ:master Oct 17, 2017
@lpichler lpichler deleted the offer_unit_in_rate_editor branch November 6, 2017 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants