miqDBBackupService - fix isModelValueNil to handle undefined #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`isModelValueNil` is supposed to return true for all nil-like values (but not 0 or false) `dbRequired` tests that to see if the depot_name is actually required .. but `depot_name` is using `dbRequired` to see if the field should be required or not setting `depot_name` to an empty string will change the model value to `undefined` and there's a watch that changes it to `null` => The value would oscilate between `undefined` and `null`, never settling, resulting in an infinite $digest Loop. This adds `undefined` to `isModelValueNil`, causing the value to always settle. https://bugzilla.redhat.com/show_bug.cgi?id=1498088 https://bugzilla.redhat.com/show_bug.cgi?id=1498097
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/647426d5e5a95099cfc778aa0055f4fe12ef991a with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go to 👤 > Configuration > Diagnostics > (current server) -> Collect Logs; Edit
Change type to something other than No Depot.
You'll get an Infinite $digest Loop warning in the browser console without this.
isModelValueNilis supposed to return true for all nil-like values (but not 0 or false)dbRequiredtests that to see if the depot_name is actually required.. but
depot_nameis usingdbRequiredto see if the field should be required or notsetting
depot_nameto an empty string will change the model value toundefinedand there's a watch that changes it to
null=> The value would oscilate between
undefinedandnull, never settling, resulting in an infinite $digest Loop.This adds
undefinedtoisModelValueNil, causing the value to always settle.https://bugzilla.redhat.com/show_bug.cgi?id=1498088
https://bugzilla.redhat.com/show_bug.cgi?id=1498097
Cc @mzazrivec