-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FINE] Cloud Subnet issue with save button #2320
Conversation
I can verify this fixes the issue in conjunction with ManageIQ/manageiq#16150, so looks good to me! |
@simaishi, could you provide an update, thanks? |
@gildub This is not a blocker for the release we're working on currently. I will merge this when we start working on the next release. |
@simaishi, no hurry then, thanks. |
Checked commits https://github.com/gildub/manageiq-ui-classic/compare/585d8f4630492420e0cbb90f0ebd0af3fe1073d9~...c3c79125e8cd41325eeeb678a3a5acb6a5e64637 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
The BZ related to this PR has quite a high priority, can we ask for review/merge? |
@gildub I meant "[FINE] BZ1467725" by "PR title" 😄 |
@simaishi, now I got it! ;-) |
ManageIQ/manageiq#16150 is merged. |
This contains backports with 3 specific cherry-picks to address "save" button issue:
Master PR: #1545
https://bugzilla.redhat.com/show_bug.cgi?id=1467725
Requires ManageIQ/manageiq#16150 to be merged first.