Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed path to jquery and jquery-ui in the asset pipeline #2318

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Oct 6, 2017

Somehow the path to the jquery and jquery-ui bower packages is not always interpolated properly in production. Found this issue while debugging some WebMKS issues in the latest upstream build. Setting the paths properly makes both issues disappear...

https://bugzilla.redhat.com/show_bug.cgi?id=1496850
https://bugzilla.redhat.com/show_bug.cgi?id=1497830

@miq-bot add_label bug, consoles

@miq-bot
Copy link
Member

miq-bot commented Oct 6, 2017

Checked commit skateman@dc98c71 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@mzazrivec mzazrivec self-assigned this Oct 9, 2017
@mzazrivec mzazrivec added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 9, 2017
@mzazrivec mzazrivec merged commit 5b9fde5 into ManageIQ:master Oct 9, 2017
@skateman skateman deleted the jquery-asset branch October 9, 2017 08:29
simaishi pushed a commit that referenced this pull request Nov 14, 2017
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit f98a889c9b7a46844aee8641241da756efa0691f
Author: Milan Zázrivec <[email protected]>
Date:   Mon Oct 9 09:59:46 2017 +0200

    Merge pull request #2318 from skateman/jquery-asset
    
    Fixed path to jquery and jquery-ui in the asset pipeline
    (cherry picked from commit 5b9fde57ebddda6cbac81c2999fd0b4ce7e3d5ed)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1500445
    https://bugzilla.redhat.com/show_bug.cgi?id=1500448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants