Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flash_msg_div from retire screen #2303

Conversation

mzazrivec
Copy link
Contributor

The div would produce warnings about duplicate ids.

@martinpovolny
Copy link
Member

@mzazrivec : if you put it like this, it's hard to review, unless I do all the research myself :-(

Where is it included from? Is it ever rendered separately? Where is it updated from?

@mzazrivec mzazrivec force-pushed the remove_flash_msg_div_from_retire_screen branch from 2e2eaaa to ed120ef Compare October 5, 2017 15:51
@miq-bot
Copy link
Member

miq-bot commented Oct 5, 2017

Checked commit mzazrivec@ed120ef with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny self-assigned this Oct 10, 2017
@chessbyte
Copy link
Member

@mzazrivec bump

@mzazrivec
Copy link
Contributor Author

@martinpovolny The thing here is that the flash_msg_div in that screen is not needed. As far as I can tell, we never render flashes when we're in the retirement screen. We only render flash messages after the retirement form submission, i.e. either in the explorer screen or the service / vm / orch. stack summary screen.

@martinpovolny martinpovolny merged commit 2b0000d into ManageIQ:master Feb 24, 2018
@martinpovolny martinpovolny added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 24, 2018
@mzazrivec mzazrivec deleted the remove_flash_msg_div_from_retire_screen branch February 26, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants