app helpers: get rid of ui_lookup() with static string argument #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzazrivec
force-pushed
the
get_rid_of_static_ui_lookup_in_helpers
branch
from
40cdceb to
0992371
Compare
| if vm_template && role_allows?(:feature => "miq_template_show") | ||
| h[:title] = _("Show this VM's %{label}") % {:label => label} | ||
| h[:title] = _("Show this VM's VM Template") |
There was a problem hiding this comment.
I know it's a different text, but "Show this VM's Template" ?
| num = @record.number_of(:floating_ips) | ||
| h = {:label => label, :icon => "ff ff-floating-ip", :value => num} | ||
| h = {:label => _('Floatin IPs'), :icon => "ff ff-floating-ip", :value => num} |
|
One question and one typo. Otherwise looks good! |
|
looking at oh yes, because now the code looks more similar |
mzazrivec
force-pushed
the
get_rid_of_static_ui_lookup_in_helpers
branch
from
0992371 to
df6223f
Compare
|
@martinpovolny yes, similar code, but that will be subject of a different PR ... :-) |
mzazrivec
force-pushed
the
get_rid_of_static_ui_lookup_in_helpers
branch
from
df6223f to
9309a84
Compare
|
Checked commit mzazrivec@9309a84 with ruby 2.3.5, rubocop 0.47.1, and haml-lint 0.20.0 |
AparnaKarve
pushed a commit
to AparnaKarve/manageiq-ui-classic
that referenced
this pull request
Oct 9, 2017
…lookup_in_helpers app helpers: get rid of ui_lookup() with static string argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.