Check for cockpit_ws server role to enable Web Console button #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
bmclaughlin
force-pushed
the
check-for-active-cockpit-role
branch
from
325f97c to
c735ad2
Compare
|
changes look good |
|
will merge once Travis errors are fixed. |
bmclaughlin
force-pushed
the
check-for-active-cockpit-role
branch
from
835c652 to
a48b91d
Compare
|
Checked commits bmclaughlin/manageiq-ui-classic@a6e0e68~...a48b91d with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 14, 2017
Check for cockpit_ws server role to enable Web Console button (cherry picked from commit 96b74b9) https://bugzilla.redhat.com/show_bug.cgi?id=1512754
|
Fine backport details: |
|
@bmclaughlin I resolved conflict backporting to Fine, but I deleted an extra character |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional check to make sure the server role 'cockpit_ws' is enabled before enabling the 'Web Console' button.
@miq-bot add_labels compute/infrastructure, compute/cloud
https://bugzilla.redhat.com/show_bug.cgi?id=1497684