-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay based retirement #2282
Delay based retirement #2282
Conversation
@serenamarie125 besides making the "spinner" controls a bit less wide, do you have any opinions on the looks of the interval selector? @Loicavenel do you think we need minutes or is that too granular? |
IMO, the numbers should be aligned, and yes the fields should be less wide. Are you using the Bootstrap Spinner? FYI PatternFly doc on the pattern can be found here if you're interested: http://www.patternfly.org/pattern-library/forms-and-controls/data-input/#/bootstrap-touchspin |
@dclarizio I am a little confused here.. I suspect we are calling it from a VM or Service to extend retirement. Today, the option was to set a Date and we try to be more granular and offer a way to extend X days, minutes etc..
@serenamarie125 I think we need a quick mockup here.. |
f5d1528
to
89c334e
Compare
89c334e
to
56e3efa
Compare
LOOKS GREAT... @serenamarie125 your view? |
56e3efa
to
5ffd4b1
Compare
@mzazrivec can you provide before screenshot as well? What options are in the first drop down "Time Delay from Now" |
94f0798
to
b60b0a9
Compare
@serenamarie125 the other option is to set the date, I don't know what is in the dropdown because before it was just the retirement date that was clickable.. |
@serenamarie125 I added some screenshots into the initial comment. |
e208d19
to
c985887
Compare
This was an OPS UI RFE that we thought we could get into this release. If you'd like to expand it to both UIs, we can do that, but will add time. Let me know. |
c985887
to
223d476
Compare
ae0e199
to
6f34511
Compare
@Loicavenel bump, see comment above |
@dclarizio let's focus on OPS UI first and port it later to SUI |
@serenamarie125 can you re-review? Thx! |
@mzazrivec we are working on some mockups, not ignoring you. Hoping to get an answer to you tomorrow. |
This enhancement allows for selecting retirement date as a time delay from now (implemented as a new angular component: datetime-delay-picker).
6f34511
to
d4a9003
Compare
Checked commit mzazrivec@d4a9003 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Merging this. UX feedback will be handled in a separate PR. Sorry. |
This enhancement allows for selecting service / vm / orchestration stack retirement date as
a time delay from now (implemented as an angular directive
datetime-delay-picker
).Initial landing screen for service / vm / orchestration stack retirement, it shows standard datetime picker
widget allowing to select specific date & time for retirement:
New functionality allows for entering the retirement date & time as a delay from now. After selecting
the option in the new dropdown menu, the following screen is shown:
The screen contains inputs for months, weeks, days and hours from now, when the item in question
would be retired. Additionally, the screen also renders the supposed retirement date.