Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort custom attributes by attribute name #228

Merged
merged 1 commit into from
Jan 26, 2017
Merged

Sort custom attributes by attribute name #228

merged 1 commit into from
Jan 26, 2017

Conversation

mzazrivec
Copy link
Contributor

@miq-bot
Copy link
Member

miq-bot commented Jan 24, 2017

Checked commit mzazrivec@5366019 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 0 offenses detected
Everything looks good. 🍰

skateman
skateman approved these changes Jan 25, 2017
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-kataria h-kataria added this to the Sprint 53 Ending Jan 30, 2017 milestone Jan 26, 2017
@h-kataria
Copy link
Contributor

looks good.

@h-kataria h-kataria merged commit 80241bf into ManageIQ:master Jan 26, 2017
@mzazrivec mzazrivec deleted the sort_custom_attributes_by_name branch February 16, 2017 14:04
@simaishi
Copy link
Contributor

simaishi commented Mar 3, 2017

Euwe backport (to manageiq repo) details:

$ git log -1
commit 609b223e250af3c9feee8caa19c6ee929df76a4a
Author: Harpreet Kataria <[email protected]>
Date:   Thu Jan 26 12:17:24 2017 -0500

    Merge pull request #228 from mzazrivec/sort_custom_attributes_by_name
    
    Sort custom attributes by attribute name
    (cherry picked from commit 80241bf7994ca5ef36f66bd7597a75a2be504a0a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1428897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@h-kataria h-kataria

Labels
bug euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mzazrivec @miq-bot @h-kataria @simaishi @skateman